Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add csv param to datasets #47

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Conversation

okotaku
Copy link
Owner

@okotaku okotaku commented Sep 2, 2023

Motivation

We can assign the CSV name to the dataset parameter as csv.

Use cases (Optional)

train_dataloader = dict(
    dataset=dict(
        csv='metadata2.csv'),
)

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

@okotaku okotaku merged commit 7c416ae into main Sep 2, 2023
2 checks passed
@okotaku okotaku deleted the feat/add_csv_param_to_datasets branch September 2, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant