Skip to content

Commit

Permalink
fix: english leak for "Close" in Autocomplete (#2291)
Browse files Browse the repository at this point in the history
OKTA-742653 English leak for "Close" in Autocomplete
  • Loading branch information
stephanieyoshimoto-okta authored and bryancunningham-okta committed Jul 25, 2024
1 parent e01eda6 commit c8d1330
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 2 additions & 0 deletions packages/odyssey-react-mui/src/Autocomplete.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,7 @@ const Autocomplete = <
// AutoComplete is wrapped in a div within MUI which does not get the disabled attr. So this aria-disabled gets set in the div
aria-disabled={isDisabled}
clearText={t("clear.text")}
closeText={t("close.text")}
disableCloseOnSelect={hasMultipleChoices}
disabled={isDisabled}
freeSolo={isCustomValueAllowed}
Expand All @@ -484,6 +485,7 @@ const Autocomplete = <
onChange={onChange}
onInputChange={onInputChange}
onFocus={onFocus}
openText={t("open.text")}
options={options}
readOnly={isReadOnly}
renderInput={renderInput}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
breadcrumbs.home.text = Home
breadcrumbs.label.text = Breadcrumbs
close.text = close
close.text = Close
clear.text = Clear
open.text = Open
picker.calendar.navigation.nextmonth = Next month
picker.calendar.navigation.previousmonth = Previous month
picker.date.toolbar.title = Selected date
Expand Down Expand Up @@ -116,4 +117,4 @@ table.rowexpansion.collapse = Collapse
table.rowexpansion.collapseall = Collapse all
dataview.layout.table = Table
dataview.layout.grid = Grid
dataview.layout.list = List
dataview.layout.list = List
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ export const Dismissible: StoryObj<ToastProps> = {
const toastElement = canvas.getByRole("status");
if (toastElement) {
const dismissToastButton = within(toastElement).getByRole("button", {
name: "close",
name: "Close",
});
if (dismissToastButton) {
userEvent.click(dismissToastButton);
Expand Down

0 comments on commit c8d1330

Please sign in to comment.