fix: add back isDisabled to MenuItem #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoislehoux-okta
requested review from
ganeshsomasundaram-okta,
KevinGhadyani-Okta,
kamronbatmanghelich-okta and
a team
as code owners
ganeshsomasundaram-okta
approved these changes
Aug 9, 2023
|
This was most likely missed in the PR that removed MUI based props in favour internally defined props (1f2369e). In the end this is a button and should probably be disableable. I don't think I can migrate to |
|
In any case, if I want to add a regression test case for this, do I simply need to add a storybook story for it? @ganeshsomasundaram-okta |
edburyenegren-okta
approved these changes
Aug 15, 2023
KevinGhadyani-Okta
deleted the
fl-OKTA-636201-add-back-isDisabled-MenuItem
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://oktainc.atlassian.net/browse/OKTA-636201