Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only apply height rules to virtualized autocomplete #2281

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Only apply height rules to virtualized autocomplete #2281

merged 1 commit into from
Jul 8, 2024

Conversation

bryancunningham-okta
Copy link
Contributor

OKTA-746694

Summary

  • Fixes a bug where autocomplete menu is longer than necessary sometimes

Testing & Screenshots

  • I have confirmed this change with my designer and the Odyssey Design Team.

@bryancunningham-okta bryancunningham-okta requested a review from a team as a code owner July 8, 2024 19:54
@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 06e3b18 into main Jul 8, 2024
1 of 2 checks passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the bc_only_apply_height_when_virtual branch July 8, 2024 20:58
stephanieyoshimoto-okta pushed a commit that referenced this pull request Jul 15, 2024
@bryancunningham-okta @stephanieyoshimoto-okta
Only apply height rules to virtualized autocomplete (#2281)
ed7d0b9 
OKTA-746694 fix(odyssey-react-mui): only apply height rules to virtualized autocomplete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinGhadyani-Okta KevinGhadyani-Okta KevinGhadyani-Okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryancunningham-okta @KevinGhadyani-Okta