build: removes yarn cache and fixes Bacon CI via Puppeteer #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est if it works" This reverts commit d313172.
.github/workflows/warm-cache.yml
Outdated
| @@ -15,7 +15,7 @@ jobs: | |||
| - name: setup node | |||
| uses: actions/setup-node@v2 | |||
| with: | |||
| node-version: v20.7.0 | |||
| node-version: v22.5.1 | |||
There was a problem hiding this comment.
I'm removing GitHub Actions in another PR, so don't worry about these.
bryancunningham-okta
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-755802
Summary
Bacon CI was totally broken because of Puppeteer. It's fix now after upgrading, but I also removed all
.yarn/cacheassets at the request of other UI Core folks and releng.Testing & Screenshots
Tested the fix already in Bacon CI using this branch.