remove _http response field

okta · Jun 21, 2022 · a67f4c9 · a67f4c9
1 parent d6ed88c
commit a67f4c9
Show file tree

Hide file tree

Showing 20 changed files with 23 additions and 295 deletions.
diff --git a/docs/myaccount/classes/BaseTransaction.md b/docs/myaccount/classes/BaseTransaction.md
diff --git a/docs/myaccount/classes/EmailChallengeTransaction.md b/docs/myaccount/classes/EmailChallengeTransaction.md
diff --git a/docs/myaccount/classes/EmailStatusTransaction.md b/docs/myaccount/classes/EmailStatusTransaction.md
diff --git a/docs/myaccount/classes/EmailTransaction.md b/docs/myaccount/classes/EmailTransaction.md
diff --git a/docs/myaccount/classes/PhoneTransaction.md b/docs/myaccount/classes/PhoneTransaction.md
diff --git a/docs/myaccount/classes/ProfileSchemaTransaction.md b/docs/myaccount/classes/ProfileSchemaTransaction.md
diff --git a/docs/myaccount/classes/ProfileTransaction.md b/docs/myaccount/classes/ProfileTransaction.md
diff --git a/lib/http/request.ts b/lib/http/request.ts
@@ -75,8 +75,6 @@ export function httpRequest(sdk: OktaAuthHttpInterface, options: RequestOptions)
       res = resp.responseText;
       if (res && isString(res)) {
         res = JSON.parse(res);
-        // Deprecated: this logic may cause confliction, use "_http" field instead 
-        // Remove in the next major version - OKTA-485317
         if (res && typeof res === 'object' && !res.headers) {
           if (Array.isArray(res)) {
             res.forEach(item => {
@@ -104,24 +102,7 @@ export function httpRequest(sdk: OktaAuthHttpInterface, options: RequestOptions)
           response: res
         });
       }
-
-      // Attach http related info to response
-      // Only apply to empty or object response
-      if (Array.isArray(res)) {
-        res.forEach(item => {
-          item._http = {
-            headers: resp.headers,
-            status: resp.status
-          };
-        });
-      } else if (!res || typeof res === 'object') {
-        res = res || {};
-        res._http = {
-          headers: resp.headers,
-          status: resp.status
-        };
-      }
-
+
       return res;
     })
     .catch(function(resp) {

diff --git a/lib/myaccount/transactions/Base.ts b/lib/myaccount/transactions/Base.ts
@@ -5,7 +5,6 @@ type TransactionOptions = {
   // TODO: move res type to http module
   res: {
     headers: Record<string, string>;
-    _http: Record<string, string | object>;
     _links?: Record<string, TransactionLink>;
     [property: string]: unknown;
   };
@@ -14,17 +13,15 @@ type TransactionOptions = {
 export default class BaseTransaction {
   // Deprecated
   headers?: Record<string, string>;
-  _http: Record<string, string | object>;
 
   constructor(oktaAuth: OktaAuthInterface, options: TransactionOptions) {
     const { res } = options;
-    const { headers, _http, ...rest } = res;
+    const { headers, ...rest } = res;
 
     // assign required fields from res
     if (headers) {
       this.headers = headers;
     }
-    this._http = _http;
 
     // add all rest fields from res
     Object.keys(rest).forEach(key => {