fix: clears refreshToken from storage when expired #1222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/oidc/util/errors.ts
Outdated
|
|
||
| export function isRefreshTokenExpiredError(error: Error) { | ||
| // error: {"error":"invalid_grant","error_description":"The refresh token is invalid or expired."} | ||
| if (error.name !== 'OAuthError') { |
There was a problem hiding this comment.
You could save a few lines here and have a reusable way of filtering errors and avoiding typecasting by using a type guard function: https://www.typescriptlang.org/docs/handbook/advanced-types.html#user-defined-type-guards
https://github.com/okta/okta-auth-js/blob/master/lib/errors/index.ts#L19
There was a problem hiding this comment.
PR updated
jaredperreault-okta
force-pushed
the
jp-OKTA-495545
branch
from
b40f772
to
204c5b7
Compare
shuowu
approved these changes
Jun 1, 2022
jaredperreault-okta
force-pushed
the
jp-OKTA-495545
branch
from
315f0ad
to
20376d9
Compare
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Jun 1, 2022
OKTA-495545 <<<Jenkins Check-In of Tested SHA: 20376d9 for [email protected]>>> Artifact: okta-auth-js Files changed count: 9 PR Link: #1222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.