select-enrollment-channel now accepts protocol-defined inputs
#1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredperreault-okta
force-pushed
the
jp-OKTA-515265
branch
from
f16d7ce
to
0b9a95d
Compare
jaredperreault-okta
changed the title
select-enrollment-channel now accepts protocol-defined inputs
shuowu-okta
reviewed
Aug 2, 2022
shuowu-okta
reviewed
Aug 2, 2022
shuowu-okta
reviewed
Aug 2, 2022
|
|
||
| if (this.values.authenticator) { | ||
| const { id, channel } = this.values.authenticator as Authenticator; | ||
| if (!!id && !!channel) { |
There was a problem hiding this comment.
both the channel and id are required
There was a problem hiding this comment.
nvm, I miss read !! to ! ...
shuowu-okta
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.