.signOut improvements #1439
Merged
.signOut improvements #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu-okta
reviewed
Jul 27, 2023
| @@ -101,7 +101,7 @@ export interface IsAuthenticatedOptions { | |||
| } | |||
|
|
|||
| export interface SignoutRedirectUrlOptions { | |||
| postLogoutRedirectUri?: string; | |||
| postLogoutRedirectUri?: string | null; | |||
There was a problem hiding this comment.
is null needed here as it's already optional?
shuowu-okta
approved these changes
Jul 27, 2023
shuowu-okta
reviewed
Jul 27, 2023
| @@ -261,7 +261,7 @@ export function mixinOAuth | |||
| if (!idToken) { | |||
| return ''; | |||
| } | |||
| if (!postLogoutRedirectUri) { | |||
| if (postLogoutRedirectUri === undefined) { | |||
There was a problem hiding this comment.
nit: add comment why undefined is handled here
There was a problem hiding this comment.
nit: not likely a real issue but I prefer to check typeof foo === 'undefined'
shawyu-okta
reviewed
Jul 27, 2023
| redirectUri.searchParams.append('state', state); | ||
| } | ||
| if (postLogoutRedirectUri === currentUri) { | ||
| // window.location.reload(); // force a hard reload if URI is not changing |
There was a problem hiding this comment.
Can this commented code be removed?
shawyu-okta
reviewed
Jul 27, 2023
Comment on lines
+295
to
+297
| (options.postLogoutRedirectUri | ||
| || this.options.postLogoutRedirectUri | ||
| || defaultUri; | ||
| || defaultUri); |
There was a problem hiding this comment.
Be careful -- options vs this.options. Is there a difference? Maybe a different variable name would help avoid confusion.
shawyu-okta
reviewed
Jul 27, 2023
| @@ -247,7 +247,7 @@ describe('OktaAuth (browser)', function() { | |||
| expect(auth.revokeRefreshToken).toHaveBeenCalledWith(refreshToken); | |||
| expect(auth.closeSession).not.toHaveBeenCalled(); | |||
| expect(window.location.assign).toHaveBeenCalledWith(`${issuer}/oauth2/v1/logout?id_token_hint=${idToken.idToken}&post_logout_redirect_uri=${encodedOrigin}`); | |||
| expect(signOutSuccess).toBeTruthy(); | |||
| expect(signOutSuccess).toBe(true); | |||
shawyu-okta
reviewed
Jul 27, 2023
Comment on lines
+200
to
201
| origin = 'https://somesite.local/'; | ||
| href = `${origin}/some-route`; |
There was a problem hiding this comment.
idk if this matters but href will have a double-/ with the change here
shawyu-okta
reviewed
Jul 27, 2023
| @@ -389,8 +396,8 @@ describe('OktaAuth (browser)', function() { | |||
| expect(auth.tokenManager.getTokensSync).toHaveBeenCalledTimes(4); | |||
| expect(auth.revokeAccessToken).toHaveBeenCalledWith(accessToken); | |||
| expect(auth.closeSession).toHaveBeenCalled(); | |||
| expect(window.location.reload).toHaveBeenCalled(); | |||
| expect(signOutSuccess).toBeTruthy(); | |||
| // expect(window.location.reload).toHaveBeenCalled(); // TODO: confirm href? | |||
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1410 and #1433
postLogoutRedirectUrito benullto invoke default/logoutredirect behaviorstateas query param to redirect uri when.signOutfalls back to.closeSession