Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

Change system fee to gas fee #1

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Change system fee to gas fee #1

merged 3 commits into from
Apr 16, 2020

Conversation

louisliu2048
Copy link

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

server/start.go Outdated Show resolved Hide resolved
client/flags/flags.go Outdated Show resolved Hide resolved
server/start.go Outdated Show resolved Hide resolved
@zhongqiuwood zhongqiuwood merged commit cde1ea8 into okx:v0.37.9-patched Apr 16, 2020
ylsGit pushed a commit that referenced this pull request Nov 17, 2020
* require old chain halts before upgrade

* Update proto/ibc/core/client/v1/client.proto

Co-authored-by: Federico Kunze <[email protected]>

* start address reviews

* Apply suggestions from code review

Co-authored-by: colin axnér <[email protected]>

* address reviews

* rework upgrade to ensure there is never more than one upgrade client in store

* fix tests

* fix conditional

* make proto-gen

* remove if statement skipping tests in upgrade keeper test

* address reviews

* correctly escape and unescape merkle keys

* add small conditional check

Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Colin Axner <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants