Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of wasm pgu #3097

Merged
merged 5 commits into from
Apr 12, 2023
Merged

fix bug of wasm pgu #3097

merged 5 commits into from
Apr 12, 2023

Conversation

yann-sjtu
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

KamiD
KamiD previously approved these changes Apr 12, 2023
KamiD
KamiD previously approved these changes Apr 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #3097 (c7308fc) into dev (9fb2deb) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head c7308fc differs from pull request most recent head 3dfe15b. Consider uploading reports for the commit 3dfe15b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev    #3097      +/-   ##
==========================================
- Coverage   35.91%   35.90%   -0.01%     
==========================================
  Files         434      434              
  Lines       45779    45779              
==========================================
- Hits        16441    16439       -2     
- Misses      28149    28150       +1     
- Partials     1189     1190       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@KamiD KamiD merged commit 48271e7 into dev Apr 12, 2023
@KamiD KamiD deleted the fix-wasm-pgu2 branch April 12, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants