Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add monitor block height metrics #3176

Merged
merged 4 commits into from
Jun 19, 2023
Merged

add monitor block height metrics #3176

merged 4 commits into from
Jun 19, 2023

Conversation

FineKe
Copy link
Contributor

@FineKe FineKe commented Jun 16, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@FineKe FineKe requested a review from chengzhinei June 16, 2023 06:25
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Merging #3176 (7e98b6e) into dev (2dbe331) will not change coverage.
The diff coverage is n/a.

❗ Current head 7e98b6e differs from pull request most recent head b782830. Consider uploading reports for the commit b782830 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev    #3176   +/-   ##
=======================================
  Coverage   36.55%   36.55%           
=======================================
  Files         443      443           
  Lines       46484    46484           
=======================================
  Hits        16991    16991           
  Misses      28228    28228           
  Partials     1265     1265           

@KamiD KamiD merged commit fccac7b into dev Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants