Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix erc20 to cw20 recipient can not use 0x prefix address #191

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

BananaLF
Copy link
Contributor

@BananaLF BananaLF commented Jul 7, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Merging #191 (8d6981e) into dev (e31a0e6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8d6981e differs from pull request most recent head 95d5f0f. Consider uploading reports for the commit 95d5f0f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #191      +/-   ##
==========================================
- Coverage   34.45%   34.45%   -0.01%     
==========================================
  Files         430      430              
  Lines       44881    44879       -2     
==========================================
- Hits        15463    15461       -2     
  Misses      28269    28269              
  Partials     1149     1149              
Impacted Files Coverage Δ
x/vmbridge/keeper/wasm.go 72.63% <100.00%> (-0.57%) ⬇️

@KamiD KamiD merged commit 1ce57a6 into dev Jul 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants