Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config initialization failure on start up, clean up configs #53

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Fix config initialization failure on start up, clean up configs #53

merged 7 commits into from
Jul 8, 2024

Conversation

sieniven
Copy link

@sieniven sieniven commented Jul 5, 2024 •
edited
Loading

Summary

  • Contains fixes for gas pricer config initialization failure on start up and default configs in PR Fix gas pricer default configs #50
  • Shifts some refactors that were initially on the apollo integration PR (a326c61) here for easier review and visibillity
  • Better X Layer related configurations design to readability and better encapsulation

@sieniven sieniven mentioned this pull request Jul 5, 2024
Closed
@sieniven sieniven mentioned this pull request Jul 5, 2024
Merged
@sieniven sieniven mentioned this pull request Jul 5, 2024
Merged
@KamiD KamiD merged commit a853ec6 into dev Jul 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjg555543 zjg555543 zjg555543 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sieniven @zjg555543 @KamiD