[smart-switch] Extend config generator for t1-smartswitch topology. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
reviewed
May 23, 2024
| data = generate_t1_sample_config(data) | ||
| data['DEVICE_METADATA']['localhost']['subtype'] = 'SmartSwitch' | ||
|
|
||
| mpbr_prefix = '169.254.200' | ||
| mpbr_address = '{}.254'.format(mpbr_prefix) | ||
|
|
||
| bridge_name = 'bridge_midplane' | ||
| data['MID_PLANE_BRIDGE'] = { |
There was a problem hiding this comment.
Can you please clarify why is this removed?
There was a problem hiding this comment.
Based on the changes in IP address assignment HLD, it is no longer needed. This configuration now sits in platform.json and is used only by midplane bridge service
dgsudharsan
approved these changes
May 23, 2024
oleksandrivantsiv
pushed a commit
that referenced
this pull request
Aug 31, 2024
…tically (sonic-net#20083) #### Why I did it src/sonic-dash-api ``` * 4919d9e - (HEAD -> master, origin/master, origin/HEAD) Allow `underlay_sip` to coexist with `vnet` in Route table (#27) (4 hours ago) [Lawrence Lee] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The Smart Switch includes two types of devices (Switch and DPU) that require the sample configuration. Generate Smart Switch sample configurations for Switch or DPU based on the device type.
Work item tracking
How I did it
Extend the sample config generator for t1-smartswitch topology.
How to verify it
Run sonic-cfggen UT.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)