Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Catalina missing system apps #285

Closed
wants to merge 1 commit into from
Closed

Fix Catalina missing system apps #285

wants to merge 1 commit into from

Conversation

underthecocotree
Copy link
Contributor

Prior to this change, while searching to find system apps there were no hits. Catalina seems to have the applications under System/Applications
eg Calendar.app Mail.app

This change adds the System/Applications folder to the default application search folders

Issue: #278

Prior to this change, while searching to find system apps there were no hits.  Catalina seems to have the applications under `System/Applications`
eg Calendar.app Mail.app

This change adds the `System/Applications` folder to the default application search folders

Issue: #278
Copy link
Owner

@oliverschwendener oliverschwendener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add this folder only if the user is running macOS Catalina or newer.

@underthecocotree
Copy link
Contributor Author

You mentioned that before and I kind of agree.

Should I add a function in src/common/helpers/operating-system-helpers.ts that checks for the version of mac running.

Then based on that add the location to the applicationFolders array.

Or we can test if the directory exists and then added that way we don't really have to check for specific os version.

What do you think?

@oliverschwendener
Copy link
Owner

I wouldn't check if the directory exists because that code should be asynchronous and this will complicate the synchronous code that merges the user configuration with the default.

I would use nodejs's os.release() API to check the current version of the operating system.

@oliverschwendener
Copy link
Owner

Will close this due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants