Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Addition of Bitconnect Coin #77

Closed
Mer-idium opened this issue Nov 17, 2017 · 15 comments
Closed

Addition of Bitconnect Coin #77

Mer-idium opened this issue Nov 17, 2017 · 15 comments

Comments

@Mer-idium
Copy link

Can we add this to the coin list please :)

@oliverw
Copy link
Owner

oliverw commented Nov 17, 2017

It appears to be a scrypt coin so adding it should be easy. What about a PR? 😄

@Mer-idium
Copy link
Author

Mer-idium commented Nov 17, 2017

@oliverw Just trying now.

        // SHA256
        { CoinType.BTC, sha256Coin },
        { CoinType.BCC, sha256Coin },
        { CoinType.NMC, sha256Coin },
        { CoinType.PPC, sha256Coin },
    { CoinType.GLT, sha256Coin },

What is the BCC sha256Coin? Bitconnect has the abbreviation of BCC and is scrypt.

I changed it to BCH as i think you mean Bitcoin Cash which is actually BCH

@oliverw
Copy link
Owner

oliverw commented Nov 17, 2017

Ok, let me just do it in a branch. I'll tell you when it's ready later today.

@Mer-idium
Copy link
Author

@oliverw I have fixed the BCH issues and added BCC and also tried to implement peercoin. No errors appear but both of them just continually say "Waiting for daemons to come online...".

I have used the same configuration file for the previous coins which has been working well. I have even copied the default configuration file from both BCC and PPC sources but still no success.

I can also use telnet IP:PORT and it comes out as connected but the server refuses to connect. Any ideas?

@oliverw
Copy link
Owner

oliverw commented Nov 17, 2017

Are you sure that the daemon runs at the correct port matching the pool config?

@oliverw
Copy link
Owner

oliverw commented Nov 17, 2017

And you are right Bitcoin Cash is using the wrong symbol BCC. That needs to be changed.

@Mer-idium
Copy link
Author

Yep the config port matches the port in the conf file for each coin. I have been using:

rpcuser=user
rpcpassword=password
rpcallowip=internal address of the server
rpcport=high port number
listen=1
server=1
daemon=1

@oliverw
Copy link
Owner

oliverw commented Nov 17, 2017

What happens if you run this (make sure to replace 1234 with the actual daemon port):

curl -u user:pass --data-binary '{"jsonrpc": "2.0", "id":"1", "method": "getnetworkinfo", "params": [] }' -H 'content-type: application/json' -X POST http://127.0.0.1:1234

If you need curl for windows look here: https://curl.haxx.se/download.html and use this command line:

curl -u user:pass --data-binary "{'jsonrpc': '2.0', 'id':'1', 'method': 'getnetworkinfo', 'params': [] }" -H "content-type: application/json" -X POST http://127.0.0.1:1234

@Mer-idium
Copy link
Author

Mer-idium commented Nov 17, 2017

Both result in the same.

{"result":null,"error":{"code":-32601,"message":"Method not found"},"id":"1"}

Does this mean that the server is trying to call "getworkinfo" but these coins dont have the corresponding rpc command?

@oliverw
Copy link
Owner

oliverw commented Nov 17, 2017

Looks like. Try "getinfo", "getmininginfo" and "getpeerinfo".

@Mer-idium
Copy link
Author

All of those work for the two coins :)

@oliverw
Copy link
Owner

oliverw commented Nov 17, 2017

Supporting them would be a bit more involved since I just phased out support for getinfo a couple days ago since all major coins will stop supporting it soon.

@Mer-idium
Copy link
Author

Ah dam, any idea when this will be done?

@oliverw
Copy link
Owner

oliverw commented Nov 17, 2017

I'll see what I can do. No promises though.

@Mer-idium
Copy link
Author

Awesome thanks

oliverw pushed a commit that referenced this issue Feb 21, 2018
* Ignore redundant ZMQ block hash updates for the same block from multiple daemons
* Disable stratum method _suggest_difficulty_ for now
* Job management change
* Runtime info logging
* Fixed GBX, CRC
* Do not return stale miner performance stats via API
* VarDiff maxDelta support
* Validate Monero PaymentID on login
* Do not send work until login is complete. Fixes #204
* Blake2s hash integration
* Support for Legacy Bitcoin daemons. Fixes #77, #119 
* Verge (XVG) integration
* Neoscrypt fix
* Legacy daemon fix
* improved POW/POS check
* Logging of block submissions
* BlockRewardMultiplier
* Increase Pg Command Timeout
* Added payment audit-trail
* Fixes #194
@calvintam236 calvintam236 added this to the 0.17 milestone Feb 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants