Get code fragment with keys #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tried running the following script https://github.com/oliviertassinari/i18n-extract/blob/master/examples/polyglot.js? Otherwise, that looks good 👍 . |
|
Yes, it is running fine on my codebase. |
|
Actually, it would be better if |
Update `extractCode` function to output the location of the extracted keys as well as the translation keys. This would close oliviertassinari#31.
|
Should be done :) |
oliviertassinari
approved these changes
Aug 3, 2017
|
@Phyks Thanks!! |
|
Thanks for the merge! May I ask you to make a new release with the included PRs? Thanks a lot! |
|
Awesome, thanks for the new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
extractCodefunction to output the location of the extractedkeys as well as the translation keys.
This would close #31.