-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore * keys for findUnused #45
Ignore * keys for findUnused #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that, it's making the key extraction issue explicit.
@Kerumen It's a great first pull request on the project 👌🏻. Thank you for giving it a shot! |
@oliviertassinari Thanks! 🙌 Can you release as |
@Kerumen Sure, I'm on it! |
This PR introduces a substantial regression, in that it reports many unused keys which are actually being used. const Yolo = ({ foo }) => <div>{i18n.t(foo, { scope: 'foo.bar' })}</div> All keys that match |
@rpellerin I might be wrong, but at first sight, your comment is exactly what motivated this change. |
Should I expect it to handle such cases in the near future? |
Amazing, thanks! |
Fix a part of #44
The ternary resolution should come in another PR.