Support Typescript #48
Conversation
| @@ -0,0 +1,6 @@ | |||
| /* eslint-disable */ | |||
|
|
|||
| import i18n from 'i18n'; | |||
There was a problem hiding this comment.
Maybe we should write some specific TypeScript in this test?
There was a problem hiding this comment.
yes you right :)
There was a problem hiding this comment.
Done @oliviertassinari
README.md
Outdated
| @@ -93,6 +93,7 @@ const keys = extractFromFiles([ | |||
|
|
|||
| - `marker`: The name of the internationalized string marker function. Defaults to `i18n`. | |||
| - `keyLoc`: An integer indicating the position of the key in the arguments. Defaults to `0`. Negative numbers, e.g., `-1`, indicate a position relative to the end of the argument list. | |||
| - `useTypescript`: Defaults to `false`. | |||
There was a problem hiding this comment.
Should we respect the case useTypeScript?
There was a problem hiding this comment.
What do you mean ?
There was a problem hiding this comment.
I believe it's TypeScript over Typescript.
There was a problem hiding this comment.
Ah yes you right !
| @@ -93,6 +93,7 @@ const keys = extractFromFiles([ | |||
|
|
|||
| - `marker`: The name of the internationalized string marker function. Defaults to `i18n`. | |||
| - `keyLoc`: An integer indicating the position of the key in the arguments. Defaults to `0`. Negative numbers, e.g., `-1`, indicate a position relative to the end of the argument list. | |||
| - `useTypeScript`: Defaults to `false`. | |||
There was a problem hiding this comment.
Instead of this boolean, maybe the API can be
parser: string with a default to flow?
This way it's extensible.
Of course this will need a throw if a unrecognized parser is passed.
There was a problem hiding this comment.
Using an enum over a boolean is more future proof. It can be interesting if Babel adds a new language in the future or even if someone wants to disable the flow plugin. I'm all 👍
There was a problem hiding this comment.
@mathieuletyrant What do you think about it?
There was a problem hiding this comment.
Yes you right it's more futur proof :)
|
@mathieuletyrant Well done! I'm gonna do a release. |
|
Too late 🙈 |
Closes #47