Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Not all nodes have loc #62

Merged
merged 1 commit into from
Nov 7, 2019
Merged

fix: Not all nodes have loc #62

merged 1 commit into from
Nov 7, 2019

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Aug 9, 2019

e.g. ones that were generated by some plugin

@magicmark
Copy link
Contributor

Thanks @oliviertassinari @sheerun for your efforts on this!

Any idea when this might be merged? Anything I can do to help?

Thanks!

@oliviertassinari
Copy link
Owner

@magicmark Well, ideally I would like to add a test case. I don't remember why I didn't merge it.

@sheerun
Copy link
Contributor Author

sheerun commented Nov 5, 2019

Sorry I don't use this currently, you'd need to add test case by yourself

@magicmark magicmark mentioned this pull request Nov 7, 2019
Merged
@oliviertassinari oliviertassinari merged commit d8e53ca into oliviertassinari:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheerun @magicmark @oliviertassinari