shutdown: Bias towards processing remaining work #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`shutdown::CancelOnShutdown` wraps a `Future` or `Stream` so that the task completes when shutdown is signaled. Currently, this is done by stopping all additional work on these tasks as soon as the shutdown signal is observed. This makes it difficult to ensure that in-flight work is processed during shutdown. This change alters the behavior so that `CancelOnShutdown` polls the inner `Future` or `Stream` before polling the shutdown watch, so that the shutdown watch is only polled when the inner instance is pending. This will, in-turn, block the shutdown and runtime futures from completing until all pending work is processed. In pathological cases, this could prevent the process from terminating gracefully. It seems better to the user or kubelet abort the application if it doesn't complete its work in a timely fashion.
olix0r
force-pushed
the
ver/cancel-tests
branch
from
300996e
to
b9682d1
Compare
hawkw
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shutdown::CancelOnShutdownwraps aFutureorStreamso that thetask completes when shutdown is signaled. Currently, this is done by
stopping all additional work on these tasks as soon as the shutdown
signal is observed. This makes it difficult to ensure that in-flight
work is processed during shutdown.
This change alters the behavior so that
CancelOnShutdownpolls theinner
FutureorStreambefore polling the shutdown watch, so thatthe shutdown watch is only polled when the inner instance is pending.
This will, in-turn, block the shutdown and runtime futures from
completing until all pending work is processed.
In pathological cases, this could prevent the process from terminating
gracefully. It seems better to the user or kubelet abort the application
if it doesn't complete its work in a timely fashion.