Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Support for Regression Models #1 #28

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Implement Support for Regression Models #1 #28

merged 4 commits into from
Oct 3, 2024

Conversation

KunjShah95
Copy link
Contributor

No description provided.

@ombhojane
Copy link
Owner

Hey @KunjShah95
to make quality contribution, it supposed to be integrated with core codes, and not another new files.

@KunjShah95
Copy link
Contributor Author

ok sharing u the code in few minutes

@KunjShah95
Copy link
Contributor Author

kindly check now

KunjShah95
KunjShah95 commented Oct 3, 2024
View reviewed changes
Copy link
Contributor Author

@KunjShah95 KunjShah95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check

ombhojane
ombhojane requested changes Oct 3, 2024
View reviewed changes
Copy link
Owner

@ombhojane ombhojane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, please have a menaingful name to this codefile like 'RegressionSupport.py' and save this in new 'examples' dir

ombhojane
ombhojane requested changes Oct 3, 2024
View reviewed changes
Copy link
Owner

@ombhojane ombhojane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make it RegressionModelSupport.py please
also create a examples dir, and save there as /examples/RegressionModelSupport.py

@KunjShah95
Copy link
Contributor Author

done kindly check

ombhojane
ombhojane approved these changes Oct 3, 2024
View reviewed changes
Copy link
Owner

@ombhojane ombhojane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
Thanks for contributing!!

@ombhojane ombhojane merged commit 90ef949 into ombhojane:main Oct 3, 2024
5 checks passed
@KunjShah95
Copy link
Contributor Author

will i get one shout on any social media platform or any ahctober fest points or anything related to it

@ombhojane
Copy link
Owner

ombhojane commented Oct 3, 2024 •
edited
Loading

sure mension ur twitter handle

you'll be rewarded with hactoberfest PR count, it'll be reflect on holopin dashboard, check hactoberfest.tech for more details

@KunjShah95
Copy link
Contributor Author

@INDIA_KUNJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ombhojane ombhojane ombhojane approved these changes

Assignees

@KunjShah95 KunjShah95

Labels
gssoc-ext hacktoberfest-accepted level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KunjShah95 @ombhojane