-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow '.' dimension separator #161
Conversation
Automated Review URLs |
👍: I think there are two remainingissues:
|
This could be a 0.4.2?
We could specify |
If there is no metadata in .zarray, then |
Do you think there is any v0.4 data out there that matches this description? That could be an argument for making this a v0.5 change. |
If there are such files, these would already be considered invalid zarr files? So, if we were to state "v0.4+ files with missing |
Not valid NGFF before this PR, exactly. They are valid V2 files, but essentially the addition of |
We already check that dimension separator is '/' for v0.2 -> v0.4: https://github.com/ome/ome-ngff-validator/pull/16/files#diff-b06a22b09da1dc9eba4472e0983b0c06000bb32a69693e8d8b86275a3034dd85R58 |
If I read the code correctly, it will yield an error if the |
@normanrz Yes. I didn't test it but I think it should do that (which is what we want, right)? |
I don't have a strong opinion about whether this should go into v0.4.2 or v0.5. However, i'm not sure if this small change is worth to trigger a v0.5 and/or to wait for bigger changes (that would definitely be a minor bump) to reach consensus. |
I'm not really sure what a It would also need the fix at ome/ome-zarr-py#235 |
Yes, they would become valid.
Yep. Not sure what other tools would need adapting. My guess is, most already support |
@will-moore: after our recent discussion, thoughts on getting this rolled into 0.5? cc: @kevinyamauchi |
@normanrz, are you still interested in pursuing this or would you prefer to focus on the move to V3? |
I am proposing to allow the
.
dimension separator alongside/
. In.zarray
there is already the relevant metadata available, which OME-NGFF can defer to.