This repository has been archived by the owner on May 2, 2024. It is now read-only.
#7 : sonar-scanner import error when empty line #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teake
suggested changes
Oct 25, 2022
| } | ||
| }, | ||
| "severity": self.sonar_checker.severity(msg), | ||
| "effortMinutes": self.sonar_checker.effort(msg) | ||
| } | ||
| if hasattr(msg, "column") and msg.column > 0: |
There was a problem hiding this comment.
There's no need to check for the column attribute, it's always there -- those other checks (for e.g. end_line) were for compatibility with older pylint versions.
Besides, there's still a chance for a SonarQube error when column is bigger than 0 but has the same value as end_column. Hence it would be better to omit end_column (which is optional in PyLint, whereas column is not) if end_column and end_line are the same as column and line, respectively.
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here the proposal solution.
Tell me if you want more details