Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-resident attribute data run + resident Index Entries in Index Root support #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

uckelman-sf
Copy link

@uckelman-sf uckelman-sf commented Jul 12, 2023

This exposes in the Python bindings the extra support provided in https://github.com/omerbenamram/mft/pulls/118.

NB: The changes in the PR against mft are required for this to compile.

@omerbenamram
Copy link
Owner

Thanks for this! Is there any specific reason you've enabled the extension module feature of PyO3? I'd like this to stay compatible with the abi3 feature set to easier support future python version, so we won't need to maintain a wheel matrix.

@kastonework
Copy link

Thanks for this! Is there any specific reason you've enabled the extension module feature of PyO3? I'd like this to stay compatible with the abi3 feature set to easier support future python version, so we won't need to maintain a wheel matrix.

Hey! Maybe I'm missing something, but extension-module was enabled before, right?
https://github.com/omerbenamram/pymft-rs/blob/master/Cargo.toml#L15

The change in this PR makes it a default feature, so it's still included by default (same as before) but we can exclude it for running cargo test (otherwise test invocation fails due to https://pyo3.rs/v0.13.2/faq.html#i-cant-run-cargo-test-im-having-linker-issues-like-symbol-not-found-or-undefined-reference-to-_pyexc_systemerror)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants