Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix maxLength to work as suggested by the jsonschema docs #156

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

lucasvmiguel
Copy link

This PR fixes the issue #155

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d5b7f1) 77.38% compared to head (0f66398) 77.38%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   77.38%   77.38%           
=======================================
  Files          18       18           
  Lines        1795     1795           
=======================================
  Hits         1389     1389           
  Misses        320      320           
  Partials       86       86           
Files Coverage Δ
pkg/generator/validator.go 94.33% <100.00%> (ø)
tests/data/validation/maxLength/maxLength.go 71.42% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasvmiguel
Copy link
Author

Could this PR be merged even with codecov complaining?

I made an one line change which has a test already.

@omissis
Copy link
Owner

omissis commented Oct 11, 2023

hi @lucasvmiguel , thanks for the contribution! I will take a look soon and hopefully merge it quickly (don't worry about codecov)

@lucasvmiguel
Copy link
Author

Hey @omissis

First of all, thanks for helping maintain this amazing package. It's helping a lot the Go community.

Don't wanna rush you guys, I know that you are probably all busy. But, do you guys know when this PR is gonna get merged? (Can I help with anything else?)

@omissis
Copy link
Owner

omissis commented Oct 21, 2023

hey, I have been sick the past week. I will check this out as soon as I will be up and running again. My estimate would be a week or two. thanks for your patience!

@omissis omissis merged commit fda3a01 into omissis:main Oct 30, 2023
3 checks passed
@omissis omissis assigned omissis and lucasvmiguel and unassigned omissis Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants