fix(relayer): ensure submission order #2198
Merged
+253
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
force-pushed
the
corver/orderedsubmits
branch
from
a87a10b
to
e2a0127
Compare
corverroos
changed the title
corverroos
force-pushed
the
corver/orderedsubmits
branch
from
e2a0127
to
e30203a
Compare
corverroos
force-pushed
the
corver/orderedsubmits
branch
from
e30203a
to
b330cd7
Compare
sideninja
reviewed
Oct 18, 2024
| returnErr := func(err error) chan error { | ||
| resp := make(chan error, 1) | ||
| resp <- err | ||
|
|
There was a problem hiding this comment.
we should close resp channel
Suggested change
| close(resp) |
There was a problem hiding this comment.
it is buffered, and we either add err or nil so I do not think we need to close it
sideninja
reviewed
Oct 18, 2024
| } | ||
| asyncResp := make(chan error, 1) // Actual async response populated by goroutine below. | ||
| go func() { | ||
| tx, rec, err := s.txMgr.Send(ctx, candidate) |
There was a problem hiding this comment.
we should close asyncResp channel, to prevent routine leak
Suggested change
| tx, rec, err := s.txMgr.Send(ctx, candidate) | |
| defer close(asyncResp) |
There was a problem hiding this comment.
no goroutines to leak
sideninja
approved these changes
Oct 18, 2024
kc1116
reviewed
Oct 18, 2024
kc1116
reviewed
Oct 18, 2024
kc1116
reviewed
Oct 18, 2024
| @@ -187,7 +187,7 @@ func newMsgStreamMapper(network netconf.Network) msgStreamMapper { | |||
|
|
|||
| func (w *Worker) newCallback( | |||
| msgFilter *msgCursorFilter, | |||
| sender SendFunc, | |||
| sendBuffer func(context.Context, xchain.Submission) error, | |||
There was a problem hiding this comment.
Suggested change
| sendBuffer func(context.Context, xchain.Submission) error, | |
| mempoolSubmit func(context.Context, xchain.Submission) error, |
nit: using sender was a bit confusing when first looking at the code
Co-authored-by: Khalil Claybon <[email protected]>
corverroos
force-pushed
the
corver/orderedsubmits
branch
from
2a60769
to
1a58425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes race condition in relayer that resulted in unordered submissions sometimes.
This refactors the
Senderto reserve nonces synchronously, but do the actual sending asynchronously. Active buffer refactored to reserves nonces synchronously ensuring strictly ordered submissions.issue: https://github.com/omni-network/ops/issues/533