Refactor access token rewrite and id_token #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the approach in #24 and #17, worked I was a bit perplexed on why in the first place we were creating a new token from the old one, overwriting Strategies::OAuth2's
@access_token
attr_reader, and creating a new token that is essentially identical to the old one.I've removed that method alias/overwrite, rely on the access_token that the base OAuth2 strategy gives us, and properly access the id_token on the access_token.
I've also fleshed out the specs a bit more, to validate that things are working as expected w/ the deleted access_token method.
I've released 2f11b42 on RubyGems as v2.0.0.rc1