-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various Python wheel generation issues #1188
Conversation
Thanks @kylc! Happy to have those changes I made put here. Something we might also want to consider is dropping the pinned version of pygccxml, and forcing only clang to be used as the compiler for the bindings (since castxml is not playing nice with modern gcc). See: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Not sure what is going on with the failed Mac build - cannot replicate that on my local machine.
py-bindings/setup.py
Outdated
@@ -49,6 +49,7 @@ def build_extension(self, ext: CMakeExtension) -> None: | |||
# EXAMPLE_VERSION_INFO shows you how to pass a value into the C++ code | |||
# from Python. | |||
cmake_args = [ | |||
"-DCMAKE_CXX_COMPILER=/usr/bin/clang++", # Force Clang for castxml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to have this be a variable with the found clang executable, not explicitly hardcoding this path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move the below clang search to above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled in your changes mostly as-is. I also bumped the CastXML version in case that separately resolves the GCC issues; I see some GCC-related commits recently in the CastXML repo. Will remove the WIP commit after the wheel job succeeds on my fork and then we can get this merged. Follow: https://github.com/kylc/ompl/actions/runs/11002295331 If you can take a look at ompl/pyplusplus#2, it fixes some errors with the Python bindings on MacOS that have been reported as issues here. |
8740aa8
to
8fc3554
Compare
Mark got there before me, but looks good to go! |
Thanks, ready to merge! |
error: no member named 'piecewise_construct' in namespace 'std';
error on MacOS by bumping Boost dependency version. See: Boost 1.79.0 errors using Xcode 15.3: upgrade to 1.84.0+ NREL/OpenStudio#5229FindBoost
(https://cmake.org/cmake/help/latest/policy/CMP0167.html)@zkingston I also pulled in your changes to fix an error in the Python binding generation due to the recent changes in include paths. These affected the CI wheel generation too, but I can wait and rebase if you want to merge those separately.
Follow here to see a successful CI build: https://github.com/kylc/ompl/actions/runs/10998657273