Check attempts is truthy before int comparison

closes #2617

onadata/apps/api/tests/viewsets/test_connect_viewset.py

@@ -2,6 +2,7 @@
 """
 Test /user API endpoint
 """
+import json
 from datetime import datetime, timedelta
 from unittest.mock import patch
 
@@ -474,11 +475,14 @@ def test_login_attempts(self, send_account_lockout_email):
         # cache value increments with subsequent attempts
         response = view(request)
         self.assertEqual(response.status_code, 401)
+        response.render()
         self.assertEqual(
-            response.data["detail"],
-            "Invalid username/password. For security reasons, "
-            "after 8 more failed login attempts you'll have to "
-            "wait 30 minutes before trying again.",
+            json.loads(response.content.decode()),
+            {
+                "detail": "Invalid username/password. For security reasons, "
+                "after 8 more failed login attempts you'll have to "
+                "wait 30 minutes before trying again."
+            },
         )
         self.assertEqual(cache.get(safe_key(f"login_attempts-{request_ip}-bob")), 2)
 

onadata/libs/authentication.py

@@ -309,7 +309,9 @@ def login_attempts(request):
     if attempts:
         cache.incr(attempts_key)
         attempts = cache.get(attempts_key)
-        if attempts >= getattr(settings, "MAX_LOGIN_ATTEMPTS", 10):
+        if attempts is not None and attempts >= getattr(
+            settings, "MAX_LOGIN_ATTEMPTS", 10
+        ):
             lockout_key = safe_key(f"{LOCKOUT_IP}{ip_address}-{username}")
             lockout = cache.get(lockout_key)
             if not lockout:
@@ -321,7 +323,7 @@ def login_attempts(request):
                 )
             check_lockout(request)
             return attempts
-        return attempts
+        return attempts if attempts is not None else 0
 
     cache.set(attempts_key, 1)