Clean up: Get OrganizationSerializer class from viewset utility fn

onaio · Aug 19, 2024 · 09b94e3 · 09b94e3
1 parent 9fa62e5
commit 09b94e3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/onadata/apps/api/tasks.py b/onadata/apps/api/tasks.py
@@ -21,7 +21,6 @@
 from onadata.apps.api.models.organization_profile import OrganizationProfile
 from onadata.apps.logger.models import Instance, ProjectInvitation, XForm, Project
 from onadata.celeryapp import app
-from onadata.libs.permissions import ROLES_ORDERED
 from onadata.libs.utils.cache_tools import invalidate_organization_cache
 from onadata.libs.utils.email import send_generic_email
 from onadata.libs.utils.model_tools import queryset_iterator

diff --git a/onadata/apps/api/viewsets/organization_profile_viewset.py b/onadata/apps/api/viewsets/organization_profile_viewset.py
@@ -130,7 +130,7 @@ def members(self, request, *args, **kwargs):
 
         serializer.save()
 
-        data = OrganizationSerializer(
+        data = self.serializer_class(
             organization, context={"request": request}
         ).data
         # pylint: disable=attribute-defined-outside-init

diff --git a/onadata/libs/utils/cache_tools.py b/onadata/libs/utils/cache_tools.py
@@ -7,6 +7,8 @@
 from django.core.cache import cache
 from django.utils.encoding import force_bytes
 
+from onadata.libs.permissions import ROLES_ORDERED
+
 # Cache names used in project serializer
 PROJ_PERM_CACHE = "ps-project_permissions-"
 PROJ_NUM_DATASET_CACHE = "ps-num_datasets-"