refactor cod

onadata/libs/serializers/user_profile_serializer.py

@@ -271,7 +271,7 @@ def create(self, validated_data):
         request = self.context.get("request")
         metadata = {}
         username = params.get("username")
-        password = params.get("password1")
+        password = params.get("password1", "")
         site = Site.objects.get(pk=settings.SITE_ID)
         new_user = None
 
@@ -288,16 +288,15 @@ def create(self, validated_data):
                 _(f"User account {username} already exists")
             ) from e
 
-        if password is not None:
-            try:
-                validate_password(password, user=new_user)
-
-            except ValidationError as e:
-                # Delete created user object if created
-                # to allow re-registration
-                if new_user:
-                    new_user.delete()
-                raise serializers.ValidationError({"password": e.messages})
+        try:
+            validate_password(password, user=new_user)
+
+        except ValidationError as e:
+            # Delete created user object if created
+            # to allow re-registration
+            if new_user:
+                new_user.delete()
+            raise serializers.ValidationError({"password": e.messages})
 
         new_user.is_active = True
         new_user.first_name = params.get("first_name")