enhance error message

onaio · Sep 19, 2024 · 7131478 · 7131478
1 parent b8a4049
commit 7131478
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/onadata/apps/api/tests/viewsets/test_data_viewset.py b/onadata/apps/api/tests/viewsets/test_data_viewset.py
@@ -3581,7 +3581,10 @@ def test_invalid_date_filters(self):
             request = self.factory.get("/?query=%s" % query_str, **self.extra)
             response = view(request, pk=self.xform.pk)
             self.assertEqual(response.status_code, 400)
-            self.assertEqual(f"{response.data['detail']}", f"Invalid date {json_date_field}")
+            self.assertEqual(
+                f"{response.data['detail']}",
+                f'Invalid date value "watermelon" for the field {json_date_field}.',
+            )
 
     def test_data_list_xml_format(self):
         """Test DataViewSet list XML"""

diff --git a/onadata/apps/viewer/parsed_instance_tools.py b/onadata/apps/viewer/parsed_instance_tools.py
@@ -76,7 +76,11 @@ def _parse_where(query, known_integers, known_decimals, or_where, or_params):
                             break
 
                     if not is_date_valid:
-                        raise InavlidDateFormat(_(f"Invalid date {field_key}"))
+                        raise InavlidDateFormat(
+                            _(
+                                f'Invalid date value "{value}" for the field {field_key}.'
+                            )
+                        )
 
                 if field_key in NONE_JSON_FIELDS:
                     where_params.extend([text(_v)])