Disable "form_versions" calculation for forms after a configurable limit

Disable "form_versions" calculation for forms that have submissions that surpass the "SUBMISSION_RETRIEVAL_THRESHOLD" setting
onaio · Dec 16, 2020 · f5c60a1 · f5c60a1
1 parent 6c38e8f
commit f5c60a1
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/onadata/libs/serializers/xform_serializer.py b/onadata/libs/serializers/xform_serializer.py
@@ -36,6 +36,11 @@
     get_enketo_urls, get_form_url)
 
 
+SUBMISSION_RETRIEVAL_THRESHOLD = getattr(settings,
+                                         "SUBMISSION_RETRIEVAL_THRESHOLD",
+                                         10000)
+
+
 def _create_enketo_urls(request, xform):
     """
     Generate enketo urls for a form
@@ -388,6 +393,8 @@ def get_form_versions(self, obj):
 
             if versions:
                 return versions
+            elif obj.num_of_submissions > SUBMISSION_RETRIEVAL_THRESHOLD:
+                return []
 
             versions = list(
                 Instance.objects.filter(xform=obj, deleted_at__isnull=True)