-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve setup.py and dependency management #1330
Conversation
Tests are failing because we need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, looks like tests need to be tweaked for this
bc7be0e
to
a137976
Compare
I'll update this to pull install_requires from requirements/base.in |
@ukanga after reading around, I am now completely convinced that we should not pull anything from the requirement files into setup.py I therefore propose to move the dependencies that we have in Please see:
|
- Only leave Django in `install_requires`. We do not use setup.py for python library dependency management and should only keep the bare minimum inside `install_requires`. Having many un-updated things here may break tools like `pip-compile` for people who include onadata in their python requirements files. - Remove `dependency_links` completely. This is more accurately handled in our requirement files. - Exclude tests and docs from `find_packages` - Add module docstring
a137976
to
9ac1f99
Compare
- Add dependencies to `install_requires` option of setup.py - Make `base.in` use dependencies from `setup.py`
I'm happy w/this @ukanga |
setup.py
to track package dependencies.base.in
read fromsetup.py
dependency_links
fromsetup.py
completely. This is more accurately handled in our requirement files.find_packages
insetup.py
setup.py
module docstringonadata
setup.py
Related reading: