Delete filtered datasets linked to a form when deleting a form #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pld
requested changes
Mar 26, 2018
There was a problem hiding this comment.
Since this is soft deleting the dataset, I think it should soft delete the filtered datasets as well (by setting an inactive flag).
Is there a reason not to do that?
Related things
- Is there a programmatic way to bring back soft deleted datasets? If there is we'd also want to modify that so brings back related solf deleted filtered datasets
- Is the filtered datasets set to accommodate soft deletes? If not we'll need to add a
deleted_at, some default filters that ignore rows where that value is set, and a db index on it
pld
requested changes
Mar 27, 2018
| def soft_delete(self): | ||
| """ | ||
| Soft deletes a dataview by adding a deleted_at timestamp and renaming | ||
| the dataview by adding a deleted-at and timestamp to the name. |
There was a problem hiding this comment.
this comment needs to explain why the deleted-at suffix is important, like the XForm soft_delete function's docstring does
|
Can you also add |
ukanga
reviewed
Mar 27, 2018
requirements/base.in
Outdated
| @@ -53,6 +53,9 @@ pymongo | |||
| dict2xml | |||
| lxml | |||
|
|
|||
| # python 3 compatibility | |||
| future | |||
There was a problem hiding this comment.
Can we please remove this requirement, I think it can come in the python-2-3 branch, the upstream package that required this onaio/python-json2xlsclient@dc545c7 handles it and as such it is not necessary to have this here.
requirements/base.pip
Outdated
| @@ -57,6 +57,7 @@ fleming==0.4.5 # via django-query-builder | |||
| formencode==1.3.1 # via pyxform | |||
| funcsigs==1.0.2 # via mock | |||
| functools32==3.2.3.post2 # via jsonschema | |||
| future==0.16.0 | |||
requirements/dev.pip
Outdated
| @@ -62,6 +62,7 @@ fleming==0.4.5 # via django-query-builder | |||
| formencode==1.3.1 # via pyxform | |||
| funcsigs==1.0.2 # via mock | |||
| functools32==3.2.3.post2 # via jsonschema | |||
| future==0.16.0 | |||
pld
approved these changes
Mar 27, 2018
- Add deleted_at field to dataview - Add soft delete method - Add test for soft delete method - Sort imports
- Remove test for deleting dataview - Clear xform_linked_dataview cache after soft deleting dataview - Add deleted_at field to dataview_serializer - Add filter to get_data_views function to remove soft deleted dataviews
xform soft_delete fuction
- Add on_delete, default and blank to the deleted_by field - Change variable from kwargs to user=None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #964