Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itemsets.csv generated from XLSForms with external_choices is inconsistent #1485

Closed
ukanga opened this issue Oct 4, 2018 · 0 comments · Fixed by #1514
Closed

itemsets.csv generated from XLSForms with external_choices is inconsistent #1485

ukanga opened this issue Oct 4, 2018 · 0 comments · Fixed by #1514
Assignees
@lincmba
Labels
Error Has-PR
Milestone
Week 50 - 51 (2018)

Comments

@ukanga
Copy link
Member

ukanga commented Oct 4, 2018 •
edited by imkingrobi
Loading

In a form with external_choices where the name column had number values, the generated itemsets.csv file is not filtering correctly on ODK Collect.

Aha! Link: https://ona.aha.io/features/PROD-310
@ukanga ukanga added the Error label Oct 4, 2018
@ukanga ukanga added this to the Week 38 - 39 (2018) milestone Oct 4, 2018
@lincmba lincmba self-assigned this Oct 30, 2018
@ukanga ukanga assigned lincmba and unassigned lincmba Oct 30, 2018
lincmba added a commit that referenced this issue Dec 6, 2018
@lincmba
Fix external Choices with number names.
cd53456 
convert integer/floats to strings if external choices have a number name

fixes #1485
@lincmba lincmba mentioned this issue Dec 6, 2018
Merged
lincmba added a commit that referenced this issue Dec 6, 2018
@lincmba
Fix external Choices with number names.
80f54dd 
convert integer/floats to strings if external choices have a number name

fixes #1485
lincmba added a commit that referenced this issue Dec 10, 2018
@lincmba
Fix external Choices with number names.
3c8c699 
convert integer/floats to strings if external choices have a number name

fixes #1485
@lincmba lincmba added the Has-PR label Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lincmba lincmba

Labels
Error Has-PR
Projects
None yet
Milestone
Week 50 - 51 (2018)
Development

Successfully merging a pull request may close this issue.

Fix external Choices with number names. onaio/onadata
3 participants
@ukanga @lincmba @faith-mutua