Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use type, name and label columns when merging forms #1587

Open
ivermac opened this issue Mar 13, 2019 · 2 comments
Open

Only use type, name and label columns when merging forms #1587

ivermac opened this issue Mar 13, 2019 · 2 comments
Assignees
Labels
Attention Required Issue requires further discussion/investigation by maintainers Discussion

Comments

@ivermac
Copy link
Contributor

ivermac commented Mar 13, 2019

The merged xform feature allows 2 or more forms to be merged when they have the same field names. We recently found out that the functionality fails if the referenced fields in one form are not available in the other forms even if they are not part of the field names that are to be merged. In our use case, there was a field referenced in the calculation column in one form but that field wasn't in the other form. The error thrown was:

Problem Merging the Form: There has been a problem trying to replace ${<field_name>} with the XPath to the survey element named 'field_name'. There is no survey element with this name.

We are thinking of only merging data in columns type, name and label and ignoring the rest - these columns can be found on the survey tab on an xls file - because at the moment, the feature doesn't support editing of data in a merged xform; editing is done on the original forms.

@ukanga
Copy link
Member

ukanga commented Mar 13, 2019

When merging forms, what functionality should be copied over?

  1. Currently, all matching questions everything (calculations, relevant, appearance, ...)
  2. Only matching questions, question type and labels? Should we remove non-existent references in this case?
  3. Everything on matching questions with non-existent references removed?

Considering we are not allowing direct data submissions or edits to the merged form.

cc: @rowo @mberg @pld

@pld
Copy link
Member

pld commented Mar 13, 2019 via email

@DavisRayM DavisRayM added the Attention Required Issue requires further discussion/investigation by maintainers label Jul 24, 2020
@DavisRayM DavisRayM added this to the Future Features milestone Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attention Required Issue requires further discussion/investigation by maintainers Discussion
Projects
None yet
Development

No branches or pull requests

5 participants