Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission Review fails when payload is used #1623

Closed
lincmba opened this issue Jun 12, 2019 · 2 comments · Fixed by #1626 or #1658
Closed

Submission Review fails when payload is used #1623

lincmba opened this issue Jun 12, 2019 · 2 comments · Fixed by #1626 or #1658
Assignees
@lincmba
Milestone
Week 25 - 26 (2019)

Comments

@lincmba
Copy link
Contributor

lincmba commented Jun 12, 2019 •
edited by imkingrobi
Loading

The feature works well when data is sent as Form Data but fails when a json Payload is used.

Aha! Link: https://ona.aha.io/features/PROD-246
@lincmba lincmba self-assigned this Jun 12, 2019
@lincmba lincmba mentioned this issue Jun 13, 2019
Merged
@lincmba lincmba added this to the Week 25 - 26 (2019) milestone Jun 13, 2019
@lincmba
Copy link
Contributor Author

lincmba commented Jul 18, 2019

Reopening issue. Bulk create of submission reviews doesn't work.

@lincmba lincmba reopened this Jul 18, 2019
lincmba added a commit that referenced this issue Jul 18, 2019
@lincmba
Bulk creation of submission reviews
137d1ef 
 Bulk creation of reviews was only implemented and tested at the serializer but not at the Viewset.
 This PR addresses this with a custom create function to handle bulk creation of submission reviews.
 fixes #1623

Signed-off-by: lincmba <[email protected]>
@lincmba lincmba mentioned this issue Jul 18, 2019
Merged
@faith-mutua
Copy link

faith-mutua commented Aug 21, 2019 •
edited
Loading

@lincmba reopening this issue. The fix is failing in both production and stage

@faith-mutua faith-mutua reopened this Aug 21, 2019
lincmba added a commit that referenced this issue Aug 29, 2019
@lincmba
Stop creation of None note.
25d61db 
 Sometimes note is left blank and sometimes it's provided as None. Both of these situations should be treated the same.
 fixes #1623

Signed-off-by: lincmba <[email protected]>
@ukanga ukanga closed this as completed in 64b6728 Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lincmba lincmba

Labels
None yet
Projects
None yet
Milestone
Week 25 - 26 (2019)
2 participants
@lincmba @faith-mutua