Catch IOError when saving osm data #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshthepitt
reviewed
Apr 25, 2018
onadata/libs/utils/osm.py
Outdated
| try: | ||
| osm_xml = osm.media_file.read() | ||
| except IOError as e: | ||
| raise Http404(str(e)) |
There was a problem hiding this comment.
Http404 will not make sense when this is run by celery as an async task. I will recommend failing silently and simply skip to the next attachment on the list.
- Catch exception and raise Http404 - Add test - Sort imports
- Change test to check that IOError is not raised and not that 404 is raised - Change att to attachment in test for clarity - Change name and docstring of test to be clearer
ukanga
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #839