Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check value of remove #1415

Merged
merged 5 commits into from
May 22, 2018
Merged

Check value of remove #1415

merged 5 commits into from
May 22, 2018

Conversation

Wambere
Copy link
Contributor

@Wambere Wambere commented May 21, 2018

The boolean value for remove is in data as a string. This checks if the value is True

@Wambere Wambere requested review from ukanga and removed request for ukanga May 21, 2018 14:13
@pld
Copy link
Member

pld commented May 21, 2018

I wonder if there are any users of the API, that assume any value passed for remove means remove, like passing 1 or something. I wonder what Zebra does?

This sort of qualifies as a non-backwards compatible API change

@Wambere
Copy link
Contributor Author

Wambere commented May 21, 2018

@pld Zebra always passes remove as either true or false
And it is specified here https://api.ona.io/static/docs/teams.html#remove-team-default-permissions-on-a-project that is should be true to remove

@pld
Copy link
Member

pld commented May 21, 2018 via email

@Wambere Wambere requested a review from ukanga May 22, 2018 09:25
@ukanga ukanga merged commit 77b6e85 into master May 22, 2018
@ukanga ukanga deleted the check-remove branch May 22, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants