New Monthly Submissions Endpoint #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Wambere
commented
May 25, 2018
•
Wambere
commented
- Add new endpoint that returns the total number of submissions to a user's private and public forms
- Add monthly submissions serializer
- Add tests
Wambere
force-pushed
the
monthly-submissions
branch
from
c46f6f1
to
5b8a45c
Compare
ukanga
requested changes
May 25, 2018
| label = 'public' if state else 'private' | ||
| result_dictionary[label] = i['num_instances'] | ||
|
|
||
| get_result() |
There was a problem hiding this comment.
I see no reason for the get_result() function, the loop block could easily be not within a function and still work.
pld
reviewed
May 25, 2018
| year = year_param if year_param else str(now.year) | ||
|
|
||
| instance_count = Instance.objects.filter( | ||
| xform__user=profile.user).filter( |
There was a problem hiding this comment.
is chaining filter instead of a single filter the best practice for this?
| result_dictionary = {} | ||
|
|
||
| def get_result(): | ||
| for state in states: |
There was a problem hiding this comment.
I think you should be able to do this without states and the extra outer loop around states
- Add monthly-submissions endpoint to the UserProfiles viewset which returns the total number of submissions in a given month to the user's forms - Add monthly submissions serializer - Add tests
- Change query to be more efficient - Optimize code in serializer
- Add validation for the query parameters in the monthly submissions endpoint - Return first item in the list, which is the dictionary with the total number of submissions - Change the tests to check for a dictionary instead of a list of a dictionary
Wambere
force-pushed
the
monthly-submissions
branch
from
650216b
to
9b44213
Compare
pld
approved these changes
May 29, 2018
ukanga
reviewed
May 29, 2018
docs/profiles.rst
Outdated
| ^^^^^^^^ | ||
|
|
||
| :: | ||
| [ |
There was a problem hiding this comment.
I think this changed, it is no longer a list but an object response.
ukanga
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.