Add Submission Review Serializer #1455
Conversation
- Add get_note_text method - Add note_text property
DavisRayM
changed the title
- Use unicode_literals from __future__
DavisRayM
changed the title
DavisRayM
changed the title
- Add new test - test_submission_review_create
DavisRayM
changed the title
| instance = Instance.objects.first() | ||
| note = Note( | ||
| instance=instance, | ||
| instance_field="", |
There was a problem hiding this comment.
Would be cool to use this _review_status as here #1428 (comment)
|
|
||
| note.save() | ||
|
|
||
| data = { |
There was a problem hiding this comment.
Is this likely to be the kind of data that we get when creating submission reviews?
DavisRayM
changed the title
- Add custom create method - Add custom update method - Add Tests
DavisRayM
changed the title
| if note_text is None: | ||
| raise exceptions.ValidationError({ | ||
| 'note': | ||
| 'Can\'t reject a submission without a comment.' |
There was a problem hiding this comment.
Can we please get this string from a common tags/strings file?
| note_data = validated_data.pop('note') | ||
| note_data['instance'] = validated_data.get('instance') | ||
| note_data['created_by'] = validated_data.get('created_by') | ||
| note_data['instance_field'] = "_review_status" |
There was a problem hiding this comment.
Lets get this string from a common tags or something file. Please look at how the logger.Instance fields are gotten. I think they come from onadata.libs.utils.common_tags
| self.assertTrue(Note.objects.filter(instance=instance).exists()) | ||
|
|
||
| note = submission_review.note | ||
| self.assertEqual(instance, submission_review.instance) |
There was a problem hiding this comment.
it would be cool to have this more consistent. Maybe expected values on the left and received values on the right?
There was a problem hiding this comment.
Updated the tests to be more consistent in the latest commits.
- Add COMMENT_REQUIRED and SUBMISSION_REVIEW_INSTANCE_FIELD tag - Update Tests
DavisRayM
force-pushed
the
add-submission-review-serializer
branch
from
8432d19
to
7e0a6d5
Compare
| note_data['created_by'] = validated_data.get('created_by') | ||
| note_data['instance_field'] = SUBMISSION_REVIEW_INSTANCE_FIELD | ||
|
|
||
| note = NoteSerializer.create( |
There was a problem hiding this comment.
Should this be?
note_serializer = NoteSerializer(data=note_data)
note_serializer.save()There was a problem hiding this comment.
We don't necessarily need the Serializer to validate the data as such i changed this to
Note.objects.create(**note_data)| with self.assertRaises(ValidationError) as no_comment: | ||
| SubmissionReviewSerializer().validate(data) | ||
|
|
||
| no_comment_error_detail = no_comment.exception.detail['note'] |
There was a problem hiding this comment.
The two lines should probably be under the with block.
| Custom update method for SubmissionReviewSerializer | ||
| """ | ||
| note = instance.note | ||
| note_data = validated_data.pop('note') |
There was a problem hiding this comment.
Is the note not being updated? Like a change in the text?
There was a problem hiding this comment.
It is being updated. We get the note_data in line 59 and change the notes text in line 61
No description provided.