Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix files endpoint for png images #1527

Merged
merged 9 commits into from
Jan 9, 2019
Merged

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Dec 27, 2018

fixes #1509

@lincmba lincmba force-pushed the 1509-fix-png-images-files-endpoint branch from 5a908ab to 27042cf Compare December 27, 2018 13:28
@lincmba lincmba requested a review from ukanga December 27, 2018 13:29
@lincmba lincmba force-pushed the 1509-fix-png-images-files-endpoint branch 3 times, most recently from 83a5a59 to 8008520 Compare December 28, 2018 11:19
@lincmba lincmba force-pushed the 1509-fix-png-images-files-endpoint branch 3 times, most recently from 1e61172 to 0017e9c Compare January 3, 2019 14:21
@ukanga
Copy link
Member

ukanga commented Jan 5, 2019

@lincmba, you may need to drop 39a3567 from the commits and rebase with master.

@lincmba lincmba force-pushed the 1509-fix-png-images-files-endpoint branch from 39a3567 to 3e110ed Compare January 8, 2019 07:05
Update image resize functions to allow dynamic file extensions

Signed-off-by: Lincoln Simba <[email protected]>
Signed-off-by: Lincoln Simba <[email protected]>
Signed-off-by: Lincoln Simba <[email protected]>
Signed-off-by: Lincoln Simba <[email protected]>
Signed-off-by: Lincoln Simba <[email protected]>
@lincmba lincmba force-pushed the 1509-fix-png-images-files-endpoint branch from 3511f7b to f44d914 Compare January 8, 2019 07:11
Signed-off-by: Lincoln Simba <[email protected]>
@lincmba lincmba force-pushed the 1509-fix-png-images-files-endpoint branch from f44d914 to 13b20d9 Compare January 8, 2019 07:49
@ukanga ukanga merged commit df1f2af into master Jan 9, 2019
@ukanga ukanga deleted the 1509-fix-png-images-files-endpoint branch January 9, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files endpoint thumbnail not working for large png images.
2 participants