Handle DataError during XForms submission. #1537
Conversation
onadata/libs/utils/logger_tools.py
Outdated
| @@ -403,14 +404,16 @@ def safe_create_instance(username, xml_file, media_files, uuid, request): | |||
| error = OpenRosaResponseBadRequest( | |||
| _(u"Unable to submit because there are multiple forms with" | |||
| u" this formID.")) | |||
| except DataError as e: | |||
| error = OpenRosaResponseBadRequest( | |||
| 'Data Incompatible with the database provided') | |||
There was a problem hiding this comment.
According to the exceptions, it seems we had a calculate field that returned an Infinity result. I am wondering whether rejecting such submissions is the right way to go about it. Can we be clear in our message of the issue so that an enumerator can know what to check and change on their end? Or should we accept the result as is and replace the Infinity with something that can be stored in a JSON field?
It would be ideal to see if we can actually replicate the issue to determine if the issue is in the data collection tools Enketo or ODK Collect and what could be potentially be solved on that end.
bmarika
force-pushed
the
handle-data-error-on-xform-submission
branch
7 times, most recently
from
71081d0
to
8fa4643
Compare
onadata/libs/utils/logger_tools.py
Outdated
| @@ -353,7 +353,8 @@ def create_instance(username, | |||
| instance.save() | |||
|
|
|||
| instance = DuplicateInstance() | |||
|
|
|||
| except DataError as error: | |||
There was a problem hiding this comment.
This except block here is irrelevant, we are not raising a specific exception. I will recommend removing it.
onadata/libs/utils/logger_tools.py
Outdated
| @@ -403,14 +404,17 @@ def safe_create_instance(username, xml_file, media_files, uuid, request): | |||
| error = OpenRosaResponseBadRequest( | |||
| _(u"Unable to submit because there are multiple forms with" | |||
| u" this formID.")) | |||
| except DataError as e: | |||
| error = OpenRosaResponseBadRequest( | |||
There was a problem hiding this comment.
Did this have to be 3 lines could, OpenRosaResponseBadRequest(str(e)) not fit within the 79/80 line limit?
bmarika
force-pushed
the
handle-data-error-on-xform-submission
branch
from
8fa4643
to
38594ec
Compare
Fixes #1535 and #949