Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick passed format or default to json in GenericRelatedField serializer #1558

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Feb 7, 2019

Widgets endpoint fail when .json is appended to the url and the format not specified
Here we get the format from kwargs or default to json

Signed-off-by: Lincoln Simba [email protected]

@lincmba lincmba changed the title Pick passed format or default to json Pick passed format or default to json in GenericRelatedField serializer Feb 7, 2019
@lincmba lincmba requested a review from ivermac February 7, 2019 07:04
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! merge if tests pass

Bump version with patch

Signed-off-by: Lincoln Simba <[email protected]>
@lincmba lincmba merged commit bd613a2 into master Feb 7, 2019
@lincmba lincmba deleted the widgets_serializer_fix branch February 7, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants