Fix form level permission restrictions on search

[lincmba]

Form level permission restrictions were failing upon searching the data.
This PR addresses this issue.

fixes #1692

Signed-off-by: lincmba [email protected]

[ukanga]

It is not clear to me how this changes and tests address the permissions issue. I think adding only the code below on line 318 in the test will result in the exact same result without any code changes.

 self.assertListEqual(
            [r['_submitted_by'] for r in response.data], ['alice', 'alice'])

[ukanga]

@lincmba Is it that the query parameter is a list instead of a string? And we only handle the case when it is a string and not a list? From the test, it is not clear that is what you check.

[lincmba]

@ukanga

Is it that the query parameter is a list instead of a string? And we only handle the case when it is a string and not a list? From the test, it is not clear that is what you check.

Yes this is exactly what was happening. We only handled the case when its either a dictionary ie query = {"_submitted_by": "bob"} or when its a string i.e query="ambulance" but not when its a list of both query=[{"_submitted_by": "bob"}, "ambulance"].

I have included more tests for clarity.