Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deleted_at to attachments #1698

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Add deleted_at to attachments #1698

merged 4 commits into from
Feb 19, 2020

Commits on Feb 19, 2020

  1. Add deleted_at Field to Attachments. 

    Create soft_delete action that will populate deleted_at field for attachments. Fixes #1696
Call soft_delete action when replacing attachments
    @WinnyTroy
    WinnyTroy committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    56e8be3 View commit details
    Browse the repository at this point in the history

  2. Include deleted_by field to the attachments models 

    Make changes as requested from revies
Update failing tests
    @WinnyTroy
    WinnyTroy committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    f98d2c7 View commit details
    Browse the repository at this point in the history

  3. Fix Flake8 errors

    @WinnyTroy
    WinnyTroy committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    c3af830 View commit details
    Browse the repository at this point in the history

  4. Included test showing replaced attachment functionality 

    Moved soft delete action to the instance model
Restructured how we call the soft_delete action when editing submissions
    @WinnyTroy
    WinnyTroy committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    953e0cf View commit details
    Browse the repository at this point in the history