Add ability to encrypt forms after creation #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukanga
reviewed
Oct 27, 2019
There was a problem hiding this comment.
I think you should look in the direction of changing the XML, see xform.py#L788 and xform.py#L180. You want to add the base64RsaPublicKey as an attribute on the submission node. If you can shift away from the regex in XML as the examples I have pointed out to by using xml.etree.cElementTree.
DavisRayM
force-pushed
the
add-encrypt-on-partial-update
branch
5 times, most recently
from
3ed5731
to
90a8dd4
Compare
DavisRayM
changed the title
ukanga
requested changes
Oct 30, 2019
DavisRayM
force-pushed
the
add-encrypt-on-partial-update
branch
3 times, most recently
from
76c7f6a
to
da766b7
Compare
- Add public_key field - Add add_xls_encryption_settings function - Add ability to replace form with an encrypted form
- Fix Issue where the xls file was unretrievable on Staging and Development servers
- Added `get_base64RsaPublicKey` helper function to retrieve base64RsaPublicKey - Added `_update_public_key` helper function to update form with the submitted public key Signed-off-by: Mark Ekisa <[email protected]> Co-authored-by: Davis Raymond <[email protected]>
Signed-off-by: Mark Ekisa <[email protected]> Co-authored-by: Davis Raymond <[email protected]>
- Clean public_key before setting - Update json and xml after public_key set - Only update json and xml when the XForm has no submissions
- Remove _clean_public_key method
- Validate public_key - Clean public_key - Test that public_key is updatable
- Minor dependency cleanup
DavisRayM
force-pushed
the
add-encrypt-on-partial-update
branch
from
da766b7
to
e8c2f28
Compare
- Utilize a proper RSA key for the test
- Fix failing tests
ukanga
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ability to encrypt forms after they have being created through a
PATCHrequest with a payload like:PATCHSample Payload